Skip to content

bootstrap: Document that setting description changes the version hash #142022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ArtemIsmagilov wants to merge 1 commit into from
Closed

bootstrap: Document that setting description changes the version hash #142022

ArtemIsmagilov wants to merge 1 commit into from

Conversation

@ArtemIsmagilov
Copy link
Contributor

@ArtemIsmagilov ArtemIsmagilov commented Jun 4, 2025 •
edited
Loading

I'm trying to solve a problem #103557
As I understand it, it is necessary to add a comment about the change description in the boostrap.example file

r? @nnethercote

@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2025

nnethercote is not on the review rotation at the moment.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2025

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@bjorn3
Copy link
Member

bjorn3 commented Jun 4, 2025

This doesn't explain what the version hash is. Instead maybe document that changing the description causes the Rust ABI to change too or something like that?

@ArtemIsmagilov
Copy link
Contributor Author

ArtemIsmagilov commented Jun 4, 2025 •
edited
Loading

Hi, thanks for noticing this.
So, it's better to rewrite?

# Changing the `description` causes the Rust ABI to change too
#description = ""

@ArtemIsmagilov
Copy link
Contributor Author

ArtemIsmagilov commented Jun 4, 2025 •
edited
Loading

Or?

# Changing `description` will be change version hash(Rust ABI)
#description = ""

@ArtemIsmagilov
Copy link
Contributor Author

ArtemIsmagilov commented Jun 5, 2025

I think my explanation doesn't get the point across. I guess I'd better cancel it.

@ArtemIsmagilov ArtemIsmagilov deleted the issue-103557 branch June 5, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtemIsmagilov @rustbot @bjorn3 @nnethercote